-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added EdgeWeightedDigraph #575
Conversation
@RaiyanC: Looks like issues in the manual: see a summary here. You can reproduce all this locally with The first thing is to note that generally tests only give the first line of an error, so
should actually just be
Also watch out for trailing whitespace, e.g. weights.xml line 28, which is 96 characters long (mostly just spaces at the end of the line). Fix these, and see what else pops up. If you can get Reminder: you can update this pull request by simply pushing more commits to your fork's AddingEdgeWeightedDigraph branch. |
Added EdgeWeights attribute, EdgeWeightedDigraph global function with additional utility functions as well as documentation, manual examples and testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No big issues here, but a few things to change. We can also talk!
@RaiyanC: you could merge or rebase on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor last changes from me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, some minor things that should be fixed before merging.
5cd58e9
to
d3fa1ac
Compare
I'm fixing this up to hopefully merge this week. Sorry we've waited so long! |
I'm satisfied that this passes, and that all @james-d-mitchell's last suggestions have been acted on. Suggest merging. |
This pull request effects: